Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multi-threading / multiple cores? #6

Open
archfrog opened this issue Jun 15, 2020 · 5 comments
Open

Support for multi-threading / multiple cores? #6

archfrog opened this issue Jun 15, 2020 · 5 comments

Comments

@archfrog
Copy link

archfrog commented Jun 15, 2020

Hi,

I regularly use WinThumbsPreloader and love it. However, it seems that it only uses a single core.

Would it be difficult to extend the app to support any number of cores for concurrent generation of thumbnails? My pictures are on an SSD and I've got a 12-core AMD Ryzen 3900X CPU.

Cheers,
Archfrog

@dadiborn
Copy link

dadiborn commented Jun 16, 2020

Hi,

I regularly use WinThumbsPreloader and love it. However, it seems that it only uses a single core.

Would it be difficult to extend the app to support any number of cores for concurrent generation of thumbnails? My pictures are on an SSD and I've got a 12-core AMD Ryzen 3900X CPU with 12 cores.

Cheers,
Archfrog

Not Agree that we need any kind of change. Try to select multiple folders and then run it from right click context menu. You will see multiple processing instances (each folder own processing), and take a look in your process manager during this :)

@archfrog
Copy link
Author

That should work for me, thanks. Please feel free to close this issue :-)

@archfrog
Copy link
Author

archfrog commented Jun 16, 2020

Uhm, I just tried on Windows 10 1909 and eleven windows pop up, but nothing happens. If I open Windows Explorer and browse to a folder that I have already generated thumbnails for, only the standard placeholder icon is shown.

Cancelling the eleven running jobs doesn't help - it seems like a deadlock of some sort as the cancel operation never completes.

I had to use Task Manager to manually close each of the eleven running instances of WinThumbsPreloader.

@meyergru
Copy link

meyergru commented Sep 3, 2020

The approach of selecting multiple directories to speed up things is not feasible when all files reside on a single drive in just one directory. I think it should be easy to parallelize processing in the main loop of ThumnailsPreloader by using await and having multiple threads, probably with a setting of how many threads to use.

@mdrejhon
Copy link

Oops, I may have made a duplicate -- #19

There is already a fork of WinThumbPreloader that is apparently multithreaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants