Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove cheatsheet hotkey on .remove() #93

Open
VangelisAlSghir opened this issue Aug 30, 2018 · 1 comment
Open

Don't remove cheatsheet hotkey on .remove() #93

VangelisAlSghir opened this issue Aug 30, 2018 · 1 comment

Comments

@VangelisAlSghir
Copy link

Is there a possibility to not remove the cheatsheet hotkey if you call hotkeysService.remove()?

Since my hotkeys have different tasks on each page, I always call .remove() in my ngOnDestroy of my components. But this also removes the hotkey trigger for the cheatsheet.

I could solve this issue with an array of my hotkeys and give it as a parameter to the remove() function. Anyway I think it would be reasonable not to delete the hotkey for cheatsheet on calling .remove() so you can always just call .remove() if you want to destroy your own hotkeys.

@VangelisAlSghir VangelisAlSghir changed the title Don't remove cheatsheet hotkey on .remove() Don't remove cheatsheet hotkey on .remove() label:question Aug 30, 2018
@VangelisAlSghir VangelisAlSghir changed the title Don't remove cheatsheet hotkey on .remove() label:question Don't remove cheatsheet hotkey on .remove() Aug 30, 2018
@wittlock
Copy link
Collaborator

This is something I've been pondering for myself as well actually. I'm currently doing the saving of hotkeys to pass to remove() but it's kind of annoying.

I'm not sure when I'll get around to it, been very busy lately, but this one is fairly high on my own wishlist so hopefully won't take too long. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants