Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular build warning: Mousetrap commonjs dependency #175

Open
joeywisse opened this issue Nov 2, 2023 · 1 comment
Open

Angular build warning: Mousetrap commonjs dependency #175

joeywisse opened this issue Nov 2, 2023 · 1 comment

Comments

@joeywisse
Copy link

While building my app I get the following warning.

Warning: /home/joey/repositories/detact/webapp/node_modules/angular2-hotkeys/fesm2022/angular2-hotkeys.mjs depends on 'mousetrap'. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
Mousetrap is used by angular2-hotkeys. I can suppress the warning by adding mousetrap to the angular.json 'allowedCommonJsDependencies' list.

CommonJS increases the bundle size https://angular.io/guide/build#configuring-commonjs-dependencies.

I would like to get rid of using mousetrap as a commonjs dependency.

@Coffee-Tea
Copy link
Collaborator

Hey, thanks for the great idea!
We're currently trying to make critical support only like real blockers or Angular version upgrades.
I have no idea regarding the business logic of this package and mousetrap usage at all. The original creator doesn't contribute here anymore. Feel free to create PR and we could review and try it out. If all will be fine it will be published.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants