Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkey params not being passed to mousetrap? #161

Open
blake-haas opened this issue Nov 14, 2022 · 0 comments
Open

Hotkey params not being passed to mousetrap? #161

blake-haas opened this issue Nov 14, 2022 · 0 comments

Comments

@blake-haas
Copy link

blake-haas commented Nov 14, 2022

I have an issue where if someone holds down the enter key, it spams the hotkey event. I thought it would be as simple as providing the @param action in the hotkey constructor to be 'keyup' but it doesn't appear to do anything. Looking deeper into the source code. It would appear that calls to mousetrap seem to omit extra parameters all together?

Looking at line 33 in hotkeys.directive.ts

Looking at line 67 in [hotkeys.service.ts]
This call to mousetrap also doesn't pass in the action parameter from the Hotkey object. It looks to be using "specificEvent" instead.

So it basically seems as though the keyup event should be passed in on the call to Add and not what is defined on the hotkey model as a parameter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant