Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add note on OTP link to config dialog #317

Open
juchem opened this issue Feb 23, 2023 · 3 comments
Open

Feature Request: add note on OTP link to config dialog #317

juchem opened this issue Feb 23, 2023 · 3 comments

Comments

@juchem
Copy link

juchem commented Feb 23, 2023

General information

The config dialog states that enabling OTP is not recommended with no explanation of why, which can be quite confusing (e.g.: is OTP not recommended or what?).

The github repo has a very nice and informative note about why that is the case, but one has to know about it to look for it. It took me a long time to find that note out.

What should happen?

This is a feature request to add a link to the note on OTP (perhaps on the not recommended text) to the config dialog, for easier discoverability. Bonus points if hoving over it gives out a brief explanation, suggesting the link for further info.

@maximbaz
Copy link
Member

Thanks for sharing your experience! This kind of feedback is important to have.

Your suggestion makes a lot of sense to me. Would you like to send a PR?

@juchem
Copy link
Author

juchem commented Feb 24, 2023

@maximbaz I'd love to. I took a stab at it and realized I'd have to learn way more about the JS framework browserpass uses than I can afford to. I might try again on a rainy day but, realistically, this is likely not going to happen any time soon.

The next best thing I could do was to give a detailed report with links to the part of the source code where I believe the change has to be made.

I understand I'm not being the most helpful. I'm genuinely sorry about it, and thankful for this great extension.

@maximbaz
Copy link
Member

No worries at all, your idea is already a valuable contribution! We'll get to this at some point 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants