-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
websites field in speakers json confusing #109
Comments
What others are thinking about it? I used the "Web" as a catch all while I was trying to rewrite the JSON document in a better format. And also because when I started to rewrite the baggers page I started replacing web icons with nice logos like I agree that's a bit restrictive though. May be we should try to open more website types, like:
I can also deal with that and solve the rendering issue on my end with some javascript and fallback to Others? What do you think? |
Ping @brownbaglunch/commiters: Any opinion? |
Maybe can we display directly the URL for websites of type Web? I don't know if this is possible? |
Changes made to the
websites
field in thespeakers json
make both contributing and browsing the site confusing.E.G.: When watching "Henri Tremblay"'s profile on the website, we can now see the following:
while before, each website was clearly specified.
To me, this change only helps the technical side, unless it's a way for you to force speakers to only specify one "Web" entry.
In that case, we should clean the existing json to force only one entry per category, as an example.
IMO, previous format was better, and it was easy to distinguish websites technically, parsing the URL.
The text was updated successfully, but these errors were encountered: