Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websites field in speakers json confusing #109

Open
Nilhcem opened this issue Jun 21, 2016 · 3 comments
Open

websites field in speakers json confusing #109

Nilhcem opened this issue Jun 21, 2016 · 3 comments

Comments

@Nilhcem
Copy link
Contributor

Nilhcem commented Jun 21, 2016

Changes made to the websites field in the speakers json make both contributing and browsing the site confusing.
E.G.: When watching "Henri Tremblay"'s profile on the website, we can now see the following:

Web
Web
Web
@henri_tremblay

while before, each website was clearly specified.

EasyMock
Objenesis
Blog
@henri_tremblay

To me, this change only helps the technical side, unless it's a way for you to force speakers to only specify one "Web" entry.
In that case, we should clean the existing json to force only one entry per category, as an example.

IMO, previous format was better, and it was easy to distinguish websites technically, parsing the URL.

@dadoonet
Copy link
Member

What others are thinking about it?

I used the "Web" as a catch all while I was trying to rewrite the JSON document in a better format. And also because when I started to rewrite the baggers page I started replacing web icons with nice logos like web.png, linkedin.png, github.png so it was easier to have a consistent naming.

I agree that's a bit restrictive though. May be we should try to open more website types, like:

  • Blog
  • Pro
  • OSS

I can also deal with that and solve the rendering issue on my end with some javascript and fallback to web.png any time I can't recognize a given website type.

Others? What do you think?

@dadoonet
Copy link
Member

dadoonet commented Nov 2, 2016

Ping @brownbaglunch/commiters: Any opinion?

@fsarradin
Copy link
Member

Maybe can we display directly the URL for websites of type Web? I don't know if this is possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants