Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEUR1630 Github Dependency #105

Merged
merged 7 commits into from
Nov 15, 2024
Merged

NEUR1630 Github Dependency #105

merged 7 commits into from
Nov 15, 2024

Conversation

anna-murphy
Copy link
Contributor

@anna-murphy anna-murphy commented Aug 27, 2024

Adds git+https://github.com/alleninstitute/abc_atlas_access.git as a dependency in requirements.txt for the NEUR1630 image.

@anna-murphy anna-murphy changed the title add git requirement NEUR1630 Github Dependency Aug 27, 2024
@anna-murphy
Copy link
Contributor Author

@digicosmos86 Might need to call in some help on this one... I've added the appropriate line to the requirements.txt file, but it looks like it can't find the repository when building it in the github action. If I do it locally, I can install it however.

$ python3 -m venv .venv
$ source .venv/bin/activate
$ pip -U install git+https://github.com/alleninstitute/abc_atlas_access.git

I also know that you can install through a requirements.txt like this because it's how I wrote the TC Cloud Model package. Any thoughts why the Github Action runner wouldn't be able to find this?

@digicosmos86
Copy link

@digicosmos86 Might need to call in some help on this one... I've added the appropriate line to the requirements.txt file, but it looks like it can't find the repository when building it in the github action. If I do it locally, I can install it however.

$ python3 -m venv .venv
$ source .venv/bin/activate
$ pip -U install git+https://github.com/alleninstitute/abc_atlas_access.git

I also know that you can install through a requirements.txt like this because it's how I wrote the TC Cloud Model package. Any thoughts why the Github Action runner wouldn't be able to find this?

Okay it's because the requirement.txt is actually installed by conda/mamba, which do not support installing from git. Looking for solutions, Hold on a sec

@digicosmos86
Copy link

Oh @anna-murphy you can actually add it to requirements.pip.txt, and then the package will be installed with pip. Let me know if this works

@anna-murphy
Copy link
Contributor Author

Good catch! This is good to merge whenever~

Copy link

@digicosmos86 digicosmos86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anna-murphy anna-murphy merged commit 0934ce5 into main Nov 15, 2024
1 check passed
@anna-murphy anna-murphy deleted the neur1630/git-dependency branch November 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants