Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Classes: PHP2560 & PHP1560 #104

Merged
merged 5 commits into from
Nov 15, 2024
Merged

New Classes: PHP2560 & PHP1560 #104

merged 5 commits into from
Nov 15, 2024

Conversation

anna-murphy
Copy link
Contributor

No description provided.

@anna-murphy anna-murphy self-assigned this Aug 26, 2024
digicosmos86
digicosmos86 approved these changes Nov 15, 2024
View reviewed changes
Copy link

@digicosmos86 digicosmos86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually PHP1560/2560 is the same class. We only need one of them. I am using the PHP2560 image so we can get rid of 1560.

@anna-murphy anna-murphy merged commit 6199b15 into main Nov 15, 2024
2 checks passed
@anna-murphy anna-murphy deleted the php2560-php1560 branch November 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digicosmos86 digicosmos86 digicosmos86 approved these changes

Assignees

@anna-murphy anna-murphy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anna-murphy @digicosmos86