Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature step4 integration #50

Merged
merged 15 commits into from
Jan 17, 2024
Merged

Feature step4 integration #50

merged 15 commits into from
Jan 17, 2024

Conversation

kmilo9999
Copy link
Collaborator

  • Added A02c_IOWAGA_thredds_prior.py
  • Added new start up configuration
  • Fixing dependencies
  • Clearing code and formatting file

@cpaniaguam cpaniaguam self-requested a review January 12, 2024 13:16
@cpaniaguam
Copy link
Member

@kmilo9999 Out of the three files changed in this PR, two are being modified in #45; the only new one is src/icesat2_tracks/analysis_db/A02c_IOWAGA_thredds_prior.py. This might lead to merge conflicts later. Should we wait until #45 is merged before reviewing this one?

@kmilo9999 kmilo9999 requested review from cpaniaguam and hollandjg and removed request for cpaniaguam January 16, 2024 21:52
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few commits. Awating for @hollandjg for review.


color_schemes.colormaps2(21)

track_name, batch_key, ID_flag = io.init_from_input(sys.argv)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Update when CLI is implemented.

Comment on lines +38 to +57
save_path = mconfig["paths"]["work"] + batch_key + "/A02_prior/"
plot_path = (
mconfig["paths"]["plot"] + "/" + hemis + "/" + batch_key + "/" + track_name + "/"
)
save_name = "A02_" + track_name
plot_name = "A02_" + track_name_short
MT.mkdirs_r(plot_path)
MT.mkdirs_r(save_path)
bad_track_path = mconfig["paths"]["work"] + "bad_tracks/" + batch_key + "/"

all_beams = mconfig["beams"]["all_beams"]
high_beams = mconfig["beams"]["high_beams"]
low_beams = mconfig["beams"]["low_beams"]

load_path_WAVE_GLO = mconfig["paths"]["work"] + "/GLOBMULTI_ERA5_GLOBCUR_01/"
file_name_base = "LOPS_WW3-GLOB-30M_"


load_path = mconfig["paths"]["work"] + batch_key + "/B01_regrid/"
Gd = h5py.File(load_path + "/" + track_name + "_B01_binned.h5", "r")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Update paths #58

import matplotlib.font_manager as font_for_print
from matplotlib.gridspec import GridSpec
import xarray as xr
from siphon.catalog import TDSCatalog
Copy link
Member

@cpaniaguam cpaniaguam Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmilo9999 It seems like this siphon dep might be missing: https://github.com/brown-ccv/icesat2-tracks/actions/runs/7557763959/job/20577748725?pr=50

I added it to the project.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was also missed from the pyprojet.toml. I added it too.

@cpaniaguam cpaniaguam self-requested a review January 17, 2024 16:46
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kmilo9999 kmilo9999 merged commit a0ee148 into main Jan 17, 2024
1 check passed
@kmilo9999 kmilo9999 deleted the feat-step4-intg branch January 17, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants