Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: logging 4 – remove prints from config directory #178

Merged
merged 9 commits into from
Mar 22, 2024

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Mar 4, 2024

@hollandjg hollandjg marked this pull request as ready for review March 4, 2024 23:39
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was easy, thanks! Just one change here.

src/icesat2_tracks/config/generate_colors.py Outdated Show resolved Hide resolved
@hollandjg hollandjg requested a review from cpaniaguam March 5, 2024 20:44
cpaniaguam
cpaniaguam previously approved these changes Mar 5, 2024
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…ger/4-replace-print-logger-config

# Conflicts:
#	src/icesat2waves/config/generate_colors.py
#	src/icesat2waves/config/startup.py
Base automatically changed from feat-logger/3-replace-print-logger-tools to main March 21, 2024 14:58
@hollandjg hollandjg dismissed cpaniaguam’s stale review March 21, 2024 14:58

The base branch was changed.

Copy link
Collaborator

@kmilo9999 kmilo9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hollandjg hollandjg merged commit 2d0bff2 into main Mar 22, 2024
2 checks passed
@hollandjg hollandjg deleted the feat-logger/4-replace-print-logger-config branch March 22, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants