Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #123

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Update Dockerfile #123

merged 6 commits into from
Mar 6, 2024

Conversation

cpaniaguam
Copy link
Member

@cpaniaguam cpaniaguam commented Feb 17, 2024

Use Python 3.11 image and install project deps.

This could be used locally/remotely for development (using for example dev-containers in VS Code/ GittHub Code Spaces), for end-users, and for faster runs on CI.

@cpaniaguam cpaniaguam added the enhancement New feature or request label Feb 17, 2024
@cpaniaguam cpaniaguam self-assigned this Feb 17, 2024
@kmilo9999
Copy link
Collaborator

@cpaniaguam @hollandjg
Can you remind me why we are keeping this PR opened?

@cpaniaguam
Copy link
Member Author

@cpaniaguam @hollandjg Can you remind me why we are keeping this PR opened?

Mainly to do faster CI runs as the current workflows install python and the other dependencies for the packages in each run. CI could run from a container from an image based on this Dockerfile.

@hollandjg
Copy link
Member

hollandjg commented Mar 4, 2024

I can't get this to build – there seems to be a problem when making the wheel for Fiona.
Here's the error I get:

10.90 Collecting fiona>=1.8.21
11.02   Downloading fiona-1.9.5.tar.gz (409 kB)
11.02      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 409.3/409.3 kB 65.9 MB/s eta 0:00:00
11.06   Installing build dependencies: started
14.94   Installing build dependencies: finished with status 'done'
14.94   Getting requirements to build wheel: started
15.04   Getting requirements to build wheel: finished with status 'error'
15.05   error: subprocess-exited-with-error
15.05   
15.05   × Getting requirements to build wheel did not run successfully.
15.05   │ exit code: 1
15.05   ╰─> [3 lines of output]
15.05       <string>:86: DeprecationWarning: The 'warn' function is deprecated, use 'warning' instead
15.05       WARNING:root:Failed to get options via gdal-config: [Errno 2
[2024-03-04T21:52:57.255Z] ] No such file or directory: 'gdal-config'
15.05       CRITICAL:root:A GDAL API version must be specified. Provide a path to gdal-config using a GDAL_CONFIG environment variable or use a GDAL_VERSION environment variable.
15.05       [end of output]
15.05   
15.05   note: This error originates from a subprocess, and is likely not a problem with pip.
15.05 error: subprocess-exited-with-error

Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've some changes to suggest in

@cpaniaguam cpaniaguam requested a review from hollandjg March 5, 2024 20:07
@cpaniaguam
Copy link
Member Author

I looked into hosting a docker image on CCV's account on docker hub. An action could be added to update the image upon merges to main. We did something like that in IceFloeTracker.jl. What do you think of that idea, @hollandjg?

@hollandjg
Copy link
Member

I looked into hosting a docker image on CCV's account on docker hub. An action could be added to update the image upon merges to main. We did something like that in IceFloeTracker.jl. What do you think of that idea, @hollandjg?

I'm sure we could, or we could put one on GHCR, but I'd be tempted just to stick with the Dockerfile – it doesn't take long to build the environment with the Dockerfile and the extra effort might not pay off. Maybe make it into an issue we could potentially solve later if it looks like it will be worth the extra effort?

Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kmilo9999 kmilo9999 self-requested a review March 6, 2024 16:42
Copy link
Collaborator

@kmilo9999 kmilo9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to tested it in my docker installation. It works fine to me

@cpaniaguam cpaniaguam merged commit 4550035 into main Mar 6, 2024
2 checks passed
@cpaniaguam cpaniaguam deleted the update-docker-file branch March 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants