-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile #123
Update Dockerfile #123
Conversation
@cpaniaguam @hollandjg |
Mainly to do faster CI runs as the current workflows install python and the other dependencies for the packages in each run. CI could run from a container from an image based on this Dockerfile. |
I can't get this to build – there seems to be a problem when making the wheel for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've some changes to suggest in
Add GDAL and LFS to Docker Config
I looked into hosting a docker image on CCV's account on docker hub. An action could be added to update the image upon merges to |
I'm sure we could, or we could put one on GHCR, but I'd be tempted just to stick with the Dockerfile – it doesn't take long to build the environment with the Dockerfile and the extra effort might not pay off. Maybe make it into an issue we could potentially solve later if it looks like it will be worth the extra effort? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to tested it in my docker installation. It works fine to me
Use Python 3.11 image and install project deps.
This could be used locally/remotely for development (using for example dev-containers in VS Code/ GittHub Code Spaces), for end-users, and for faster runs on CI.