Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli step 7 b06 correct #113

Merged
merged 9 commits into from
Feb 16, 2024

Conversation

kmilo9999
Copy link
Collaborator

@kmilo9999 kmilo9999 commented Feb 7, 2024

Adding CLI to step 7

  • Files formatted and cleaned
  • Added workflow for step7 CLI

@cpaniaguam cpaniaguam changed the base branch from main to 95-cli-step-5-b04_anglepy February 7, 2024 22:20
@kmilo9999 kmilo9999 marked this pull request as ready for review February 15, 2024 20:29
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on getting the cli set up and making the paths work! Thanks Camilo!!

I pointed out some opportunities for refactoring the code. Some reflect my personal style (like moving a block of code to a function) but a number of others will make the code more pythonic. Let me know what you think!

.github/workflows/test-B01_SL_load_single_file.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/icesat2_tracks/app.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
src/icesat2_tracks/analysis_db/B06_correct_separate_var.py Outdated Show resolved Hide resolved
@cpaniaguam cpaniaguam self-requested a review February 16, 2024 22:36
Copy link
Member

@cpaniaguam cpaniaguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@kmilo9999 kmilo9999 merged commit bca4f19 into 112-cli-step-6-b04_define_anglepy Feb 16, 2024
1 check passed
@kmilo9999 kmilo9999 deleted the cli-step-7-b06_correct branch February 16, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants