Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create module that references constants #65

Closed
kmilo9999 opened this issue Jan 12, 2024 · 0 comments · Fixed by #86
Closed

Create module that references constants #65

kmilo9999 opened this issue Jan 12, 2024 · 0 comments · Fixed by #86
Assignees
@cpaniaguam
Labels
enhancement New feature or request

Comments

@kmilo9999
Copy link
Collaborator

kmilo9999 commented Jan 12, 2024 •
edited by cpaniaguam
Loading

Suggestion for a new issue: Perhaps we should replace 9.81 (which is used through this function) with a variable? It'll be the standard gravitational acceleration, so we could call it g = 9.81 or gravitational_acceleration = 9.81 and then use that wherever it's used. There might be other places where we have something similar, and perhaps we want to do that everywhere.

Originally posted by @hollandjg in #45 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpaniaguam cpaniaguam

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add scipy.constants.g and use it for calculations brown-ccv/icesat2waves
2 participants
@kmilo9999 @cpaniaguam