BREAKING CHANGE: Switch to vite with electron-forge
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that's right, I looked for things that would break existing apis. I didn't see anything, but I could be wrong! Just wanted to check what you thought |
build: Remove uneeded depencies
fix: Fix window differences beteem dev and prod
fix: Add serialport code as its own file again
…into type-module
BREAKING CHANGE: Update data paths
ref: `type: module`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches Honeycomb to the Vite compiler. Note that we use a Vite plugin (for
electron-forge) to run the app inside an Electron browser.electron-forgewhen running the applicationdevscript - we always pass a.env.*fileimport.meta.envfrom Vite instead ofprocess.envFirebase
npm ci && npm run build:firebasefrom the GH actionsnpm ciandnpm run build:firebaseas predeploy scripts infirebase.jsonNote that by doing this change the user doesn't have to worry about adding the predeploy script when they initialize Firebase hosting. One less step to simplify the onboarding process but I will have to update the documentation