Rewrite crypto-js in ES6 #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Evan @evanvosberg , do you have any time to review the code ? |
|
希望添加index.d.ts |
|
@SilkageNet 欢迎从 npm 上引入使用。 There is an alternative for this repo, just the same as it and written in ECMAScript 6+ and with TypeScript support: crypto-es . |
|
@Alanscut I'm so sorry, I still did not find to review this. |
|
@evanvosberg this PR can solve a lot of issues with crypto-js size on production builds. It would be great if you find some time to review it. |
Open
|
Any reason why this was abandoned? it would be really great to see this merged |
|
bump :) |
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rewrite crypto-js in ES6, and change the test framework to jest.