Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (or organize) registered typos in genres #788

Open
maztt opened this issue Oct 11, 2023 · 1 comment
Open

Fix (or organize) registered typos in genres #788

maztt opened this issue Oct 11, 2023 · 1 comment
Labels
needs review Needs review

Comments

@maztt
Copy link

maztt commented Oct 11, 2023

Describe the bug
This is not necessarily an occurring or fatal bug, but a bug that may occur once #767 is implemented. I was able to capture it while I was working on that feature.

To Reproduce
I created the example on my computer, but it's possible to see it while searching through the current list.

Steps to reproduce the behavior:

  1. Go to your search bar in your IDE;
  2. Simply type genres: [
  3. Scroll down to see the occurrances.

Expected behavior
I believe genres should be registered with a specified format, and a few of them are recorded with blank spaces, inconsistency on lowercase, duplicated names, and not split, as the screenshot shows below.

Screenshots
emojiscreen_typos

Desktop

  • OS: Windows
  • Browser: Google Chrome

Additional context

I believe this will naturally be kinda complicated to control, so every once in a while somebody should make a review on the current registered data and fix the typos.

EXTRA: Also a new instruction to https://github.com/brittanyrw/emojiscreen/blob/main/docs/card_overview.md#card-pull-request-checklist should help new contributors to correctly fill the fields.

@maztt maztt added the needs review Needs review label Oct 11, 2023
@maztt
Copy link
Author

maztt commented Oct 11, 2023

I currently have two PRs that should help the issue.

One for fixing the typos.
Another one for adding the "EXTRA" suggestion.

@brittanyrw If you find this issue assertive, I'd like to contribute with both PRs in this Hacktoberfest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs review
Projects
None yet
Development

No branches or pull requests

1 participant