Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing links for TV shows #769

Open
brittanyrw opened this issue Oct 6, 2023 · 3 comments
Open

Add missing links for TV shows #769

brittanyrw opened this issue Oct 6, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brittanyrw
Copy link
Owner

In the tv.js file, some objects are missing itemLink. Add them in and link to the correct IMDB page for that TV show.

Make sure the link includes https or http at the beginning. The link must be wrapped in quotation marks.

@brittanyrw brittanyrw added enhancement New feature or request good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 6, 2023
@Mikerniker
Copy link

Hello, can I be assigned to this? And can you help clarify if these the steps I need to follow to fix the missing itemLink?: https://github.com/brittanyrw/emojiscreen/blob/main/docs/github_ui_walkthrough.md
Thank you!

@brittanyrw
Copy link
Owner Author

brittanyrw commented Oct 6, 2023

Hi @Mikerniker yes, I will assign you to this issue. To fix the missing itemLink, go into the tv.js file and find the objects that do not have itemLink. Then you will need to get the link for that show in IMDB and add an itemLink key to the object.

Make sure there is a comma between the new itemLink and the previous key in the object.

Here is a video of how to add the itemLink. https://github.com/brittanyrw/emojiscreen/assets/23530405/871c30aa-12a7-427b-a25b-52be5bc5bac3

Yes, you can do it through the GitHub UI instructions if you prefer.

@Mikerniker
Copy link

Thank you, @brittanyrw ! Will start working on it and send the PR for your approval when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants