Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added legend, fixed label cut-off issue, and changed default threshold, colour function, font sizes, ... #12

Merged
merged 17 commits into from
May 7, 2020

Conversation

mariamarab
Copy link
Member

@mariamarab mariamarab commented May 7, 2020

Changes made:

  • Added a legend displaying the colours for positive and negative correlation
  • Fixed the label cutoff issue (the chart will be re-sized by @innovate-invent)
  • Fixed the default threshold to be 0.0, since the 0.4 default threshold was causing issues. It is also more intuitive to display the entire data upon uploading, since not everyone would immediately know that we cut off some of their data.
  • Fixed arc width to be a function of font size
  • Fixed chart height to be a function of the maximum label width
  • Fixed link colour function

@mariamarab
Copy link
Member Author

@innovate-invent I'm using the positiveCorrelationColor and negativeCorrelationColor props, but it seems like they don't trigger an update on the legend

@innovate-invent
Copy link
Collaborator

@innovate-invent I'm using the positiveCorrelationColor and negativeCorrelationColor props, but it seems like they don't trigger an update on the legend

You need to add an explicit @watch function similar to this that watches both 'positiveCorrelationColor' and 'negativeCorrelationColor' and updates the legend.

@Watch('positiveCorrelationColor')
@Watch('negativeCorrelationColor')
updateLegend(): void {
...
}

See https://github.com/kaorun343/vue-property-decorator#Watch

@mariamarab mariamarab requested a review from innovate-invent May 7, 2020 16:50
@innovate-invent
Copy link
Collaborator

Would you like me to make that change?

@mariamarab
Copy link
Member Author

Would you like me to make that change?

That would be great!

This was linked to issues May 7, 2020
@github-actions
Copy link

github-actions bot commented May 7, 2020

Pull request has been successfully built and is ready for review at https://mariam-414429337-globecorr.stage.brinkmanlab.ca/

@innovate-invent
Copy link
Collaborator

I believe the tooltip for the labels hasn't been implemented for when they are truncated.
Was this feature dropped? or in a future PR?

innovate-invent
innovate-invent previously approved these changes May 7, 2020
@mariamarab mariamarab changed the title Added legend, fixed label cut-off issue, and changed default threshold Added legend, fixed label cut-off issue, and changed default threshold, colour function, font sizes, ... May 7, 2020
@mariamarab mariamarab merged commit 56762ab into master May 7, 2020
@innovate-invent innovate-invent deleted the mariam branch May 12, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long globe labels cut off Globe Legend
2 participants