-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added legend, fixed label cut-off issue, and changed default threshold, colour function, font sizes, ... #12
Conversation
@innovate-invent I'm using the positiveCorrelationColor and negativeCorrelationColor props, but it seems like they don't trigger an update on the legend |
You need to add an explicit @watch function similar to this that watches both 'positiveCorrelationColor' and 'negativeCorrelationColor' and updates the legend. @Watch('positiveCorrelationColor')
@Watch('negativeCorrelationColor')
updateLegend(): void {
...
} See https://github.com/kaorun343/vue-property-decorator#Watch |
Would you like me to make that change? |
That would be great! |
Pull request has been successfully built and is ready for review at https://mariam-414429337-globecorr.stage.brinkmanlab.ca/ |
I believe the tooltip for the labels hasn't been implemented for when they are truncated. |
…riam � Conflicts: � src/components/ExposomeGlobe.vue
Changes made: