Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SASS #42

Open
ikbenben opened this issue Dec 5, 2014 · 2 comments
Open

Add support for SASS #42

ikbenben opened this issue Dec 5, 2014 · 2 comments

Comments

@ikbenben
Copy link
Collaborator

ikbenben commented Dec 5, 2014

from @asenseofdesign: This is an exciting extension. However, it would be even greater if it was compatible with SASS. Is it in your plans? :-)

@ikbenben
Copy link
Collaborator Author

ikbenben commented Dec 5, 2014

we will need to investigate this.

the way the extension gets the css rules is different with how the default css inline editor gets the rules. this extension queries the html dom using the getMatchedCSSRules() method while the default css inline editor simply scans the CSS/SASS/LESS files in the project filesystem. The latter approach will result in matches that may not be actual matches. I'm guessing the brackets used this approach in order to support SASS and LESS.

in order to implement this, we will need to change the way the extension gets the CSS rules for a particular dom element

@unknownterritory
Copy link

Thank you, ikbenben, for referencing this issue here. In a project that uses SASS or LESS, the rules in those preprocessors files are the ones that actually reflect the the intention of the developer at that point in time, so not matching the actual css rules is not a problem as these are just a later sub-product. Also, when someone makes the choice of using a preprocessor, that choice is usually something that doesn't change throughout the duration of the whole project... So, what about inserting this in some sort of settings or preferences for the extension? That way the parsing could be redirected accordingly... if this makes sense at all to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants