Use Electron's shell.openpath() for pcap slices (#2992)

apps/zui/src/domain/env/plugin-api.ts

@@ -1,6 +1,5 @@
 import env from "src/app/core/env"
 import {getPath} from "src/js/api/core/get-path"
-import open from "src/js/lib/open"
 import {join} from "path"
 
 export class EnvApi {
@@ -20,10 +19,6 @@ export class EnvApi {
     return env.isTest
   }
 
-  openExternal(uri: string, opts: {newWindow?: boolean} = {}) {
-    return open(uri, opts)
-  }
-
   getExePath(relPath: string) {
     return join(getPath("zdeps"), relPath) + (env.isWindows ? ".exe" : "")
   }

apps/zui/src/electron/ops/open-link-op.ts

@@ -1,6 +1,6 @@
 import {createOperation} from "../../core/operations"
-import open from "src/js/lib/open"
+import {shell} from "electron"
 
 export const openLinkOp = createOperation("openLinkOp", (_ctx, url: string) => {
-  open(url)
+  shell.openExternal(url)
 })

apps/zui/src/js/components/Login.test.tsx

@@ -10,9 +10,7 @@ import Login from "./Login"
 import {rest} from "msw"
 import LakeStatuses from "../state/LakeStatuses"
 import lake from "../models/lake"
-import open from "src/js/lib/open"
-
-jest.mock("src/js/lib/open", () => jest.fn())
+import {shell} from "electron"
 
 const system = new SystemTest("Login.test.ts")
 
@@ -76,12 +74,12 @@ function getLake() {
 }
 
 async function expectBrowserToOpen() {
-  await waitFor(() =>
-    expect(open).toHaveBeenCalledWith(
+  await waitFor(() => {
+    expect(shell.openExternal).toHaveBeenCalledWith(
       expect.stringContaining("http://test.com/authorize?")
     )
-  )
-  const auth0Url = (open as jest.Mock).mock.calls[0][0]
+  })
+  const auth0Url = (shell.openExternal as jest.Mock).mock.calls[0][0]
   const urlParts = url.parse(auth0Url, true)
   return urlParts.query.state
 }

apps/zui/src/plugins/brimcap/packets/download.ts

@@ -2,9 +2,10 @@ import * as zed from "@brimdata/zed-js"
 import {join} from "path"
 import {createCli} from "../cli"
 import os from "os"
-import {window, env, commands} from "src/zui"
+import {window, commands} from "src/zui"
 import {queryForConnLog} from "./query-conn-log"
 import {DOWNLOAD} from "./types"
+import {shell} from "electron"
 
 function getSearchArgsFromConn(conn: zed.Record) {
   const dur = conn.try("duration") as zed.Duration
@@ -38,7 +39,7 @@ export async function downloadPackets(root: string, pool: string, uid: string) {
       const msg = JSON.parse(err)?.error || `brimcap search failed: ${err}`
       window.showErrorMessage(msg)
     } else {
-      env.openExternal(dest)
+      shell.openPath(dest)
       window.showSuccessMessage("Packets extracted. Opening...")
     }
   }