Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All methods' metadata['unit'] are 'Unknown' when importing Ecoinvent with ecoinvent_interface and using namespaced methods #274

Closed
tngTUDOR opened this issue Sep 12, 2024 · 1 comment · Fixed by #275

Comments

@tngTUDOR
Copy link
Contributor

Current

When importing ecoinvent using ecoinvent_interface all the units in the methods end up being "Unknown".

Expected

the metadata item 'unit' for the methods are set to the values from the xlsx LCIA Implementation spreadsheet.

@tngTUDOR tngTUDOR changed the title All method metadata['unit'] are 'Unknown' when importing Ecoinvent with ecoinvent_interface All methods' metadata['unit'] are 'Unknown' when importing Ecoinvent with ecoinvent_interface and using namespaced methods Sep 12, 2024
@tngTUDOR
Copy link
Contributor Author

When the key is recovered at:

unit=units_mapping.get(key, "Unknown"),

it's probably not found when namespaced methods are used.

the units_mapping is built earlier with:

units_mapping = {
(row["method"], row["category"], row["indicator"]): row[units_col_label]
for row in units
}

but when using namespaced methods, the key of the units_mapping is missing the namespace

@tngTUDOR tngTUDOR mentioned this issue Sep 13, 2024
@tngTUDOR tngTUDOR linked a pull request Sep 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant