Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player renders twice in strict mode #102

Open
mikehilario opened this issue Sep 6, 2022 · 13 comments
Open

Player renders twice in strict mode #102

mikehilario opened this issue Sep 6, 2022 · 13 comments

Comments

@mikehilario
Copy link

Screen Shot 2022-09-06 at 4 15 43 PM

Player renders twice in strict mode. Please see codesandbox: https://codesandbox.io/s/ml6vzj

@jhopley-stadion
Copy link

Yea i am getting the same issue? Did you resolve this?

@mikehilario
Copy link
Author

Unfortunately, no. @jhopley-stadion

@jhopley-stadion
Copy link

Nightmare! Is anyone supporting this repo?

@vyangit
Copy link

vyangit commented Oct 7, 2022

Try setting: embedType='iframe'

@SuperCrunchTime
Copy link

Also having this issue.

@ganapathyraiker
Copy link

ganapathyraiker commented Mar 23, 2023

Hello, are there any solution for this observation ? for embedType='in-page'

@Unicornelia
Copy link

I am also fighting this issue, this is a nightmare, anybody any suggestions?

@labgit771
Copy link

I am also fighting this issue, this is a nightmare, anybody any suggestions?
This works:

@labgit771
Copy link

labgit771 commented Jan 15, 2024

Render it as type iframe, it works..

embedType='iframe'

@Unicornelia
Copy link

Render it as type iframe, it works..

embedType='iframe'

I think it depends on how the video was uploaded, that is why the iframe works, as long as I understood the docs

@labgit771
Copy link

Render it as type iframe, it works..
embedType='iframe'

I think it depends on how the video was uploaded, that is why the iframe works, as long as I understood the docs

Yeah, but sometime as a dev we don't have access to BrightCode account to manage video to see how it was uploaded. But yeah , i agree with you !

@dannydebug
Copy link

This issue got resolved in the new published version 1.5.0.

@rsauchuck-gp
Copy link

rsauchuck-gp commented Aug 7, 2024

Using version 1.5.0 I randomly get an empty div the same style as the div wrapping the video player

<div style="padding-top: 177.778%;"></div>
<div style="padding-top: 177.778%;"><video-js></video-js><div>

When the guard triggers correctly I do not get the extra div

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants