Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.22.0 is not pushed / tagged #243

Closed
robin-kunzler opened this issue Oct 21, 2021 · 4 comments
Closed

Version 0.22.0 is not pushed / tagged #243

robin-kunzler opened this issue Oct 21, 2021 · 4 comments

Comments

@robin-kunzler
Copy link

robin-kunzler commented Oct 21, 2021

The latest rustls 0.20.0 now uses webpki 0.22.0 and this is also on crates.io, but that version does not seem to exist in this repository.

It would be great for us to have the code pushed here due to the following reasons:

  1. Since this is a security critical component, it is important that the diff to the previous version is public and can be reviewed.
  2. We would like to patch version 0.22.0 with PR 241 until that PR is merged and released, but we cannot because the code is not public.

Could you please push version 0.22.0 and tag the releases? This would be very much appreciated, thanks!

@randombit
Copy link

The revision 0b7cbf2 seems to be 0.22 so possibly it's just that the tag was not pushed?

@fspreiss
Copy link

fspreiss commented Dec 7, 2021

Is this indeed just a matter of a missing tag? If so, it would be great if the respective tag could be pushed. @briansmith, you are the author of the commit in question, so it would be great if you could comment on this and/or push the tag.

As @robin-kunzler already pointed out, having the tag pushed is also important for projects such as Rustls that rely on webpki so that (security) code reviews can be performed and patches can be created (if necessary). Thanks!

@briansmith
Copy link
Owner

It's been my policy to not do git tags for releases. In the next release, I plan to start tagging releases.

@briansmith
Copy link
Owner

I filed #250 so everybody can track how this will work going forward. Please comment there if you have ideas about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants