Merge branch 'feature-influx2' of https://github.com/breadlysm/speedtest-to-influxdb into feature-influx2 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config now sits as a global variable within speedflux. It can access settings more dynamically and allows for quicker adding of new settings. Most functions are currently broken until code rewrite is complete
Refactored to match the new layout of config and logs.
Refactored to bring logs into global scope. no longer need to import logs into every file. Importing speedflux and using .LOG has same function
Now uses the global scopes for config and logging. Influx initiation is also done on a global scope now too.
speedflux can utilize the config, logging, and influx DB anywhere in the code by just importing speedflux.
fixed brand name
…est-to-influxdb into feature-influx2
breadlysm
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not completely necessary, I rewrote the config module. This will make for a smoother addition of influx2.
It now functions from a more global scope and is initialized during app startup.
This has a few benefits.
(It was bothering me to see full configs in clear text while debugging.)
Downsides, The config request lines are a bit longer.