Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing developer nav #8145

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Removing developer nav #8145

merged 3 commits into from
Sep 24, 2024

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Sep 24, 2024

Why are you making this change? (required)

The developer_nav is fairly unintuitive--mostly due to not being a standard feature on other tech-doc sites. Furthermore, this feature will be removed as a part of the #8078. Because of these reasons, we are opting to remove this feature now.

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@internetisaiah internetisaiah self-assigned this Sep 24, 2024
@cla-bot cla-bot bot added the cla-signed label Sep 24, 2024
@internetisaiah internetisaiah marked this pull request as ready for review September 24, 2024 17:56
@internetisaiah
Copy link
Contributor Author

@zzhaobraze , i'm sure theres a much more elegant way to remove this, but i didn't know if this function was being called/used elsewhere. feel free to commit a better fix. thanks!

@zzhaobraze
Copy link
Collaborator

can delete this file and remove it from _includes/html_include.html

@internetisaiah
Copy link
Contributor Author

@zzhaobraze , done ✅ . let me now if i removed the right line from html_include.html.

Copy link
Collaborator

@zzhaobraze zzhaobraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good but i'll just double check locally nothing breaks

@internetisaiah
Copy link
Contributor Author

@zzhaobraze , no errors locally for me. gonna ship it 👍🏽

@internetisaiah internetisaiah merged commit 8d8dbd4 into develop Sep 24, 2024
3 checks passed
@internetisaiah internetisaiah deleted the internetisaiah-patch-5 branch September 24, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants