Tag Insertion Dialog #267
Merged
Tag Insertion Dialog #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
braxtonhall
commented
Jan 14, 2023
braxtonhall
commented
- toward Insert new tags into tag index #212
- resolves trim tags in sheet #266
- toward Add scroll shadows to Modals #259
aymendirar
approved these changes
Jan 15, 2023
Comment on lines
16
to
21
| // { | ||
| // kind: "button", | ||
| // text: "Insert Tags", | ||
| // colour: UIColour.GREY, | ||
| // onClick: async () => resolve(insertTags(invalidTags).then(() => saveHandler({noCache: true}))), | ||
| // }, |
There was a problem hiding this comment.
i know we're working towards some tickets in this PR, but do we want this here?
| import {UIColour} from "../../../../../common/ui/colour"; | ||
| import {getSheetLink} from "../../../../../common/entities/spreadsheet"; | ||
| import {GetTagsOptions} from "../types"; | ||
| // import {insertTags} from "./insertTags"; |
| ) | ||
| ); | ||
|
|
||
| export {insertTags}; |
| for (let node = trees.get(tag.toLowerCase()); node; node = node.parent) { | ||
| ancestry.push(node.tag); | ||
| for (let node: TagTree["parent"] = nodes.get(tag.toLowerCase()); node && "parent" in node; node = node.parent) { | ||
| // TODO maybe we should detect collisions here and then create a modal? |
There was a problem hiding this comment.
how often does this code get run? and what would the user do with this information if we show them the modal?
There was a problem hiding this comment.
I think maybe the modal should happen at a later step.
For example, when adding ancestor tags.
Or maybe? Instead of a tree its a network, and we just go for it and add all ancestors on multiple paths?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.