Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for italic style #72

Open
jwortmann opened this issue Feb 28, 2020 · 2 comments
Open

Add filter for italic style #72

jwortmann opened this issue Feb 28, 2020 · 2 comments

Comments

@jwortmann
Copy link

Hi, very nice and useful website! By the way, it was just mentioned in the German c't magazine (biggest IT related print magazine in europe I think).

I would like request a filter for fonts with italic variant, because the slanted version of fonts without italic variant displayed by editors usually looks rather poor in comparison with "real" italic style. A new filter button with an italic/slanted "i" could be added next to the "ligatures" filter button. Or maybe replace the "no ligatures" filter button with it (because I don't see a reason why I would want to explicitely filter for "no ligatures" fonts). And add "italic" to the displayed font details (sans/serif, ligatures) if available. As the required information are already in the JSON, you just would have to check if the "variants" key is present and contains "italic", and adjust the applyFilters function with it. I guess I could create a PR for that if desired, however I don't know how to create a svg image for the "i" button. What do you think?

@braver
Copy link
Owner

braver commented Feb 29, 2020

German c't magazine (biggest IT related print magazine in europe I think)

No shit 😱

The main problem here is that the variants information is incomplete right now. I try to add more every once in a while, and especially for new entries, but I need to go back and cover what’s already in there. I totally agree though, having real italics is something I would be looking for.

@braver
Copy link
Owner

braver commented Sep 9, 2023

I'm setting this to won't fix for the time being. Besides the effort of correctly and completely recording the availability of an italic font, there are variable fonts to consider that provide a "slant" axis of customization. Maybe "has true italics" could be a useful boolean, but even then, does that mean a download simply comes with a true italic ttf or otf file? Or that a customized version with italics could be made? Also, true bold, and true bold-italic are in some cases just as important.. it's just too complicated. I've resorted to giving a summary of the available variants in text, it's up to the user to figure out if what's provided will fit their purpose.

This of course also means that the existing zero-style info is also already broken in a similar way: some fonts allow you to pick alternatives. Again I try to hint at this in a description as best as is reasonably possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants