Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap rule it's too noisy #527

Open
1 of 6 tasks
thypon opened this issue Mar 1, 2024 · 0 comments
Open
1 of 6 tasks

unwrap rule it's too noisy #527

thypon opened this issue Mar 1, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@thypon
Copy link
Member

thypon commented Mar 1, 2024

Reference: ...

Proposed Solution

  • Remove the rule

  • Fork and improve the rule:

    • Only do it for unwrap and assume that expect means that someone at least thought about why it cannot happen.
    • Ignore any file in examples/, tests/, benches/ (if not already done)
    • Ignore #[test] functions
    • Create a custom clippy lint, so that we can prevent the warnings from semgrep by checking/fixing them locally first
@thypon thypon added the bug Something isn't working label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants