-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Ledger wallet: unable to start Web3 call after signing Solana message #1090
Comments
Does this reproduce with MetaMask when using Ledger too? |
Sorry I meant Phantom |
Haven't checked with Ledger+Phantom. Will check and update in a comment |
@srirambv - thanks for checking. at least we know we are "ledger compatible with phantom". all - i don't know what the root cause is here, i'll do a little research. i'll make sure our FAQ notes this limitation. |
@srirambv - can you verify whether "blind signing" is enabled on the Solana Ledger App? if enabled, does the issue occur for either the Brave or Phantom wallets? |
@mrose17 the problem is when trying to join the Solana call on a different browser (Brave/Edge with Phantom) it doesn't recognize the Solana account. It automatically selects Ethereum accounts so no way to get it to perform Solana sign |
i think we are talking about two different things. the video in the original report above shows someone trying to create a call using a SOL address on a ledger wallet and getting an error. can you reproduce that error with "blind signing enabled? |
@hadiamjad - can you confirm that when someone goes to join a call that was created with SOL NFT token gating, that the initial error response they get indicates two things: "this is a web3 call" and "use a SOL wallet"? it seems that what is reported here is that the second indication isn't sent or is being ignored... |
Yes. even with "blind signing" enabled it still shows the same error message |
to confirm:
|
Yes. Trying to create a room with Solana Ledger fails
Yes. With blind signing enabled, creating a room it shows the same error as shown in #1090 (comment)
Yes |
@hadiamjad - TL;DR: the ledger hardware wallet doesn't do the kind of signing we want, so this issue is outside of scope for now; however, please look into #1090 (comment) and, if we're not doing this now, please create an issue and then make this change. thanks! |
hello is there an solution to this problem? of-late i'm facing this. |
Hello! I am in the process of reviewing Brave Talk issues and this one is very interesting... |
@srirambv - may i impose you to see if this still reproduces? |
This still seems to be an issue with Ledger accounts brave_lkXT3hqBCV.mp4 |
Description
Unable to start Web3 call after signing Solana message
Steps to reproduce
Error signing message
and doesn't start the callActual Result
Solana.Ledger.Web3.Call.mp4
Expected Result
Able to start Web3 call without issues
Additional Information
cc: @mrose17 @HEagle18
The text was updated successfully, but these errors were encountered: