Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Ledger wallet: unable to start Web3 call after signing Solana message #1090

Open
srirambv opened this issue Jul 5, 2023 · 17 comments
Open
Assignees
Labels

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jul 5, 2023

Description

Unable to start Web3 call after signing Solana message

Steps to reproduce

  1. Initiate a Web3 call
  2. Select Solana
  3. Select Ledger Solana account to connect
  4. Click on Start a Web3 Call
  5. Sign the message
  6. Shows Error signing message and doesn't start the call

Actual Result

Solana.Ledger.Web3.Call.mp4

Expected Result

Able to start Web3 call without issues

Additional Information

cc: @mrose17 @HEagle18

@srirambv srirambv added bug Something isn't working wallet-support web3 labels Jul 5, 2023
@mrose17 mrose17 changed the title Unable to start Web3 call after signing Solana message Using Ledger wallet: unable to start Web3 call after signing Solana message Jul 5, 2023
@bbondy
Copy link
Member

bbondy commented Jul 20, 2023

Does this reproduce with MetaMask when using Ledger too?

@bbondy
Copy link
Member

bbondy commented Jul 20, 2023

Sorry I meant Phantom

@srirambv
Copy link
Collaborator Author

Haven't checked with Ledger+Phantom. Will check and update in a comment

@srirambv
Copy link
Collaborator Author

Same issue with Phantom as well but it provides more info as to why its failing rather than just saying Cannont read properties of undefined
image

@mrose17
Copy link
Member

mrose17 commented Jul 21, 2023

@srirambv - thanks for checking. at least we know we are "ledger compatible with phantom".

all - i don't know what the root cause is here, i'll do a little research. i'll make sure our FAQ notes this limitation.

@mrose17
Copy link
Member

mrose17 commented Jul 21, 2023

@srirambv - can you verify whether "blind signing" is enabled on the Solana Ledger App? if enabled, does the issue occur for either the Brave or Phantom wallets?

@srirambv
Copy link
Collaborator Author

srirambv commented Jul 21, 2023

@mrose17 the problem is when trying to join the Solana call on a different browser (Brave/Edge with Phantom) it doesn't recognize the Solana account. It automatically selects Ethereum accounts so no way to get it to perform Solana sign

@mrose17
Copy link
Member

mrose17 commented Jul 21, 2023

i think we are talking about two different things.

the video in the original report above shows someone trying to create a call using a SOL address on a ledger wallet and getting an error. can you reproduce that error with "blind signing enabled?

@mrose17
Copy link
Member

mrose17 commented Jul 21, 2023

@mrose17 the problem is when trying to join the Solana call on a different browser (Brave/Edge with Phantom) it doesn't recognize the Solana account. It automatically selects Ethereum accounts so no way to get it to perform Solana sign

@hadiamjad - can you confirm that when someone goes to join a call that was created with SOL NFT token gating, that the initial error response they get indicates two things: "this is a web3 call" and "use a SOL wallet"? it seems that what is reported here is that the second indication isn't sent or is being ignored...

@srirambv
Copy link
Collaborator Author

the video in the original report above shows someone trying to create a call using a SOL address on a ledger wallet and getting an error. can you reproduce that error with "blind signing enabled?

Yes. even with "blind signing" enabled it still shows the same error message

@mrose17
Copy link
Member

mrose17 commented Jul 21, 2023

to confirm:

  • this is for someone creating a room (not joining)
  • they are using a ledger wallet in which "blind signing" is enabled on the SOL application on the ledger wallet
  • this fails for both the Brave and Phantom wallets

@srirambv
Copy link
Collaborator Author

srirambv commented Jul 21, 2023

this is for someone creating a room (not joining)

Yes. Trying to create a room with Solana Ledger fails

they are using a ledger wallet in which "blind signing" is enabled on the SOL application on the ledger wallet

Yes. With blind signing enabled, creating a room it shows the same error as shown in #1090 (comment)

this fails for both the Brave and Phantom wallets

Yes

@mrose17
Copy link
Member

mrose17 commented Jul 21, 2023

@hadiamjad - TL;DR: the ledger hardware wallet doesn't do the kind of signing we want, so this issue is outside of scope for now; however, please look into #1090 (comment) and, if we're not doing this now, please create an issue and then make this change. thanks!

@mrose17 mrose17 added the solana label Jul 28, 2023
@t98rex
Copy link

t98rex commented Mar 20, 2024

hello is there an solution to this problem? of-late i'm facing this.
blind signing is enalbled but the signing transaction never makes it to my ledger.

@mrose17
Copy link
Member

mrose17 commented Mar 22, 2024

Hello! I am in the process of reviewing Brave Talk issues and this one is very interesting...

@mrose17
Copy link
Member

mrose17 commented Jun 17, 2024

@srirambv - may i impose you to see if this still reproduces?

@srirambv
Copy link
Collaborator Author

This still seems to be an issue with Ledger accounts

brave_lkXT3hqBCV.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants