Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Enable ScrollToTextFragment #10787

Closed
Inesicen opened this issue Jul 17, 2020 · 4 comments
Closed

[Desktop] Enable ScrollToTextFragment #10787

Inesicen opened this issue Jul 17, 2020 · 4 comments
Labels
closed/wontfix OS/Desktop privacy-pod Feature work for the Privacy & Web Compatibility pod

Comments

@Inesicen
Copy link

Make ScrollToTextFragment optional for those who accept the alleged/dubious privacy implications and want to use the feature anyway.

@rebron rebron added the privacy-pod Feature work for the Privacy & Web Compatibility pod label Sep 2, 2020
@rebron
Copy link
Collaborator

rebron commented Sep 24, 2020

Marking this as wontfix as we don't plan on doing any work here including surfacing UI for it. This looks like a good candidate as an extension for those who want it.

@PolicyPuma4
Copy link

PolicyPuma4 commented May 20, 2021

Marking this as wontfix as we don't plan on doing any work here including surfacing UI for it. This looks like a good candidate as an extension for those who want it.

It's really disappointing that this is the stance Brave has on this issue. Removing useful features with not even a flag to enable them is not something I can stand by myself.

Also just to add you can't install extensions on Brave Android so it seems if this is the stance Brave has on the issue Android users will never see this feature.

@Redsandro
Copy link

Redsandro commented May 29, 2021

This looks like a good candidate as an extension for those who want it.

There are hundreds of useful flags in brave://flags/ and this one in particular is a good example of something that should be handled by the browser where it's safe. No one wants this moved to a third party extension that would need a blanket approval of permission to read and change every page you visit. It's a security hazard waiting to happen.

You might want to make this upstream feature opt-in rather than removing it altogether. If the concern is recording the page jump, an interesting compromise might be to do mark the text, but don't jump to the text.

Please reconsider @rebron

@fdavis99
Copy link

If you desire this option please upvote #42393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix OS/Desktop privacy-pod Feature work for the Privacy & Web Compatibility pod
Projects
None yet
Development

No branches or pull requests

6 participants