Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid argument when mapping from QEMU 9p virtio share #8

Open
ktprograms opened this issue Jun 15, 2022 · 7 comments
Open

Invalid argument when mapping from QEMU 9p virtio share #8

ktprograms opened this issue Jun 15, 2022 · 7 comments

Comments

@ktprograms
Copy link

Hi, I found out about ID-mapped mounts from LWN and found this tool.

I was able to make it work mounting a regular directory, but when I tried to ID-map a directory mounted from QEMU 9p virtio share, I get an Invalid argument error. I'm on Alpine aarch64, with kernel 5.15.29. Commands ran and output below:

~/mount-idmapped (master)> doas mount -t 9p -o trans=virtio virt9pshare /mnt/ -oversion=9p2000.L
~/mount-idmapped (master)> doas ./mount-idmapped --map-mount=u:501:1000:1 --map-mount=g:20:1000:1 /mnt /mnt-mapped
Invalid argument - Failed to change mount attributes
@brauner
Copy link
Owner

brauner commented Jun 15, 2022

Hey @ktprograms creating idmapped mounts requires filesystem support and 9p simply hasn't been converted to support idmapped mounts yet.

@ktprograms
Copy link
Author

Ah, I see. From reading the description of it I thought it didn't require filesystem support.

Would there be any way to do ID-mapping for 9pfs?

@brauner
Copy link
Owner

brauner commented Jun 15, 2022

In principle 9pfs can support this going forward.

@ktprograms
Copy link
Author

What changes would need to be made?

Could you please link to the implementation for other filesystems so I can take a look? I wouldn't mind looking at trying to implement it.

@brauner
Copy link
Owner

brauner commented Jun 16, 2022

Yeah, I can certainly help you there. Is it ok if I wait until after next week. I won't have time before that.

@ktprograms
Copy link
Author

ktprograms commented Jun 16, 2022 via email

@ktprograms
Copy link
Author

Hi @brauner, do you have some links to documentation/other implementations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants