Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the prepare_install_2_6.sh script installLmSensors function. #2

Open
ggreen88 opened this issue Jan 7, 2013 · 5 comments

Comments

@ggreen88
Copy link

ggreen88 commented Jan 7, 2013

The installLmSensors function doesn't take into account the graphics card. The file it download is setup for nvidia not ati. I ended up using the HOW-TO from here http://youresuchageek.blogspot.fr/2012/06/xbmc-install-and-config-howto-for-linux.html to update it.

@bramvanoploo
Copy link
Owner

I'm aware it's only working for Nvidia cards. I just haven't come around to adding ATI support. Thanks for scharing the howto. I'll integrate support for this in the next release.

@un1versal
Copy link
Contributor

There is zero need for some random how-to what ATI cards need is compatible advancedsettings.xml.

<advancedsettings>
  <cputempcommand>sensors|sed -ne "s/temp1: \+[-+]\([0-9]\+\).*/\1 C/p"</cputempcommand>
  <gputempcommand>/usr/bin/aticonfig --od-gettemperature | grep Temperature | cut -f 2 -d "-" | cut -f 1 -d "." | sed -e "s, ,," | sed 's/$/ C/'</gputempcommand>
</advancedsettings>

Problem solved, not that I use ATI that was ripped from http://forum.xbmc.org/showthread.php?tid=116996

@un1versal
Copy link
Contributor

part of this could be implemented now

un1versal@96b7bcd

@un1versal
Copy link
Contributor

Can this be done?

function installLmSensors()
{
    showInfo "Installing temperature monitoring package (apply all defaults)..."
    aptInstall lm-sensors
    clear
    echo ""
    echo "$(tput setaf 2)$(tput bold)INSTALLATION INFO: Please confirm all questions with ENTER (applying the suggested option)."
    echo "$(tput setaf 2)The XBMC installation will continue automatically when finished.$(tput sgr0)"
    echo ""
    echo ""

    sudo sensors-detect

    if [ ! -e "$XBMC_ADVANCEDSETTINGS_FILE" ]; then
    if [[ $GFX_CARD == NVIDIA ]]; then
        createDirectory "$TEMP_DIRECTORY" 1 0
        download $DOWNLOAD_URL"temperature_monitoring.xml"
        createDirectory "$XBMC_USERDATA_DIR" 0 0
        IS_MOVED=$(move $TEMP_DIRECTORY"temperature_monitoring.xml" "$XBMC_ADVANCEDSETTINGS_FILE")

        if [ "$IS_MOVED" == "1" ]; then
            showInfo "Temperature monitoring successfully enabled in XBMC"
        else
            showError "Temperature monitoring could not be enabled in XBMC"
        fi
    fi
fi
    if [[ $GFX_CARD == AMD ]]; then
        createDirectory "$TEMP_DIRECTORY" 1 0
        download $DOWNLOAD_URL"amd-temperature_monitoring.xml"
        createDirectory "$XBMC_USERDATA_DIR" 0 0
        IS_MOVED=$(move $TEMP_DIRECTORY"temperature_monitoring.xml" "$XBMC_ADVANCEDSETTINGS_FILE")

        if [ "$IS_MOVED" == "1" ]; then
            showInfo "Temperature monitoring successfully enabled in XBMC"
        else
            showError "Temperature monitoring could not be enabled in XBMC"
        fi
    fi

    showInfo "Temperature monitoring successfully configured"

@bramvanoploo
Copy link
Owner

I'll have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants