Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of bv_env #96

Closed
sapetnioc opened this issue May 16, 2023 · 4 comments
Closed

Get rid of bv_env #96

sapetnioc opened this issue May 16, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@sapetnioc
Copy link
Member

Now that we are using a container, I believe that we do not need bv_env anymore. All environment variables can be set at casa-distro level. If we get rid of bv_env, there would be no more compiled code in brainvisa-cmake. This would simplify branvisa-cmake installation and remove obsolete code. But this would also make it possible to make brainvisa-cmake installable with pip. This is not very useful for users but would make the test of new compilation environments much more easy by removing the need to have a first build of brainvisa-cmake and to switch later to the version in build directory. Using bv_maker in sync with source code could be made possible after simply download the sources directory and use pip install --editable <brainvisa-cmake sources>.

@sapetnioc sapetnioc added the enhancement New feature or request label May 16, 2023
@sapetnioc
Copy link
Member Author

sapetnioc commented May 16, 2023

Removing bv_env and bv_env.sh requires to make changes in casa-distro as well as in images. For instance, brainvisa-cmake version is included in dev images and VirtualBox desktop icons use bv_env. Therefore, I will start by just trying to make them scripts instead of compiled software. This should be enough to be able to use bv_maker directly from source.

@denisri
Copy link
Contributor

denisri commented May 16, 2023

Removing bv_env would thus also completely forbid to build the BrainVisa environment outside of a container, thus possibly contradicts brainvisa/casa-distro#345, wouldn't it ? I'm not saying that we should not remove it, but I'm trying to think of all consequences.

@sapetnioc
Copy link
Member Author

I am currently working on this casa-distro issue and my goal in not to forbid compilation from outside a container but to make compilation from scratch simpler. You are probably right that removing bv_env is a bad idea. But replacing it by a script could allow the simplification I want. What I have in mind is to have bv_maker behave as close as possible as casa_distro. It can be executed transparently from various directories: source, build and installation. I'd like to be able to run a first bv_maker from source tree (giving bv_maker.cfg as a parameter or environment variable) and then to go on using the one in build tree.

@sapetnioc
Copy link
Member Author

I close this issue to make a new one with a better goal definition and description of what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants