-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of bv_env #96
Comments
Removing |
Removing bv_env would thus also completely forbid to build the BrainVisa environment outside of a container, thus possibly contradicts brainvisa/casa-distro#345, wouldn't it ? I'm not saying that we should not remove it, but I'm trying to think of all consequences. |
I am currently working on this casa-distro issue and my goal in not to forbid compilation from outside a container but to make compilation from scratch simpler. You are probably right that removing |
I close this issue to make a new one with a better goal definition and description of what to do. |
Now that we are using a container, I believe that we do not need
bv_env
anymore. All environment variables can be set at casa-distro level. If we get rid ofbv_env
, there would be no more compiled code in brainvisa-cmake. This would simplify branvisa-cmake installation and remove obsolete code. But this would also make it possible to make brainvisa-cmake installable withpip
. This is not very useful for users but would make the test of new compilation environments much more easy by removing the need to have a first build of brainvisa-cmake and to switch later to the version in build directory. Usingbv_maker
in sync with source code could be made possible after simply download the sources directory and usepip install --editable <brainvisa-cmake sources>
.The text was updated successfully, but these errors were encountered: