Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CI failures 2024-01-24 #322

Closed
willGraham01 opened this issue Jan 24, 2024 · 1 comment
Closed

[BUG] CI failures 2024-01-24 #322

willGraham01 opened this issue Jan 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@willGraham01
Copy link
Contributor

willGraham01 commented Jan 24, 2024

CI seems to be failing due to bad data collection in the test_gene_expression test in test_integration.py.

Failures seem to happen at random across multiple OSes and Python versions. First noticed in #320, but then attempted to run on a branch identical to main and got similar results in #321. I would guess it's some sort of connection problem since some of #320's tests managed to pass the second time round, but not the first. Python 3.9 and 3.10 consistently fail at different points however.

I cannot replicate this bug by running the tests locally through tox on my machine, nor by performing the test steps manually in a Python terminal. So either it's the GitHub runners or there's a configuration on my work PC.

As an aside, this repo's test workflow does not have a workflow_dispatch trigger which makes debugging of this kind very hard (requires one to open a pull request and push to it to trigger any sort of testing). This feature is added in #320, once we get to the bottom of this.

@willGraham01 willGraham01 added the bug Something isn't working label Jan 24, 2024
@willGraham01
Copy link
Contributor Author

Closing as it looks like whatever issue was causing this (runners or Allen institute itself) looks to have been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant