Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellfinder v1.3.0 blog post #177

Closed
adamltyson opened this issue May 9, 2024 · 8 comments · Fixed by #197
Closed

cellfinder v1.3.0 blog post #177

adamltyson opened this issue May 9, 2024 · 8 comments · Fixed by #197
Assignees
Labels
enhancement New feature or request

Comments

@adamltyson
Copy link
Member

The next version of cellfinder is likely to be a (relatively) large one, and we should write a blog post to outline the differences. This will include:

cc @alessandrofelder

@adamltyson adamltyson added the enhancement New feature or request label May 9, 2024
@IgorTatarnikov
Copy link
Member

Here are the graphs and correlation/coefficients comparing tensorflow to torch on both Brain 1 and Brain 2 from the paper:

comparison_left

comparison_right

The timing information is below:

Brain 1 - paper Brain 1 - torch Brain 2 - paper Brain 2 - torch Brain 2 - torch + new detection
Candidate detection 50 46.5 48 64.5 48
Classification 33 35.5 43 39 39.5
Total 83 82 91 103.5 87.5

@adamltyson
Copy link
Member Author

To clarify some points @IgorTatarnikov:

  • Based on the plots, torch is (technically, very slightly) better than TF?
  • The detection timings, is the main section of the plot the timings from the latest release, and "new detection" is from main (after @matham's PR)?

@IgorTatarnikov
Copy link
Member

Correct, seems torch is a tiny bit better than TF.

For detection timings, all were run on the original machine from the paper. The "paper" columns are numbers taken from the cellfinder paper, the "torch" columns are the means of two runs using the detection code that is in the current release but with a torch backend. The last column is combining the new detection from brainglobe/cellfinder#407 with a torch backend.

@adamltyson
Copy link
Member Author

So to summarise, the next release will be pretty much the same accuracy and speed (but easier to maintain for us)?

@IgorTatarnikov
Copy link
Member

Yup! It might be interesting to include some comparisons using a c-fos brain. I'm curious how the new release will compare to the old release with millions of cell candidates.

@adamltyson
Copy link
Member Author

@alessandrofelder do you happen to have any data like this to hand?

I think we should include it if we have it, otherwise we can post something later on. This blog post could end up being longer than the original paper otherwise!

@adamltyson
Copy link
Member Author

Due to various updates to other packages, have decided to create a blog post for the new version of the metapackage. This blogpost can be solely about the move to torch.

@adamltyson adamltyson changed the title cellfinder v1.2.0 blog post cellfinder v1.3.0 blog post May 16, 2024
@alessandrofelder
Copy link
Member

@alessandrofelder do you happen to have any data like this to hand?

Yes, I'll DM @IgorTatarnikov the details to it on our internal storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants