Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid all-catch Exception #40

Open
alessandrofelder opened this issue Nov 13, 2023 · 0 comments
Open

Avoid all-catch Exception #40

alessandrofelder opened this issue Nov 13, 2023 · 0 comments
Labels
enhancement New feature or request migrated-from-cellfinder For issues that were inherited from the migration of cellfinder into this package.

Comments

@alessandrofelder
Copy link
Member

alessandrofelder commented Nov 13, 2023

We have a catch-all exception at https://github.com/brainglobe/cellfinder/blob/21f724b46c84cf2c2489d1d4347c6c19f9277b45/cellfinder/analyse/analyse.py#L96. We should narrow this down to catch only the exceptions we expect to happen here, as this may cause bugs to go unnoticed.

@alessandrofelder alessandrofelder added the enhancement New feature or request label Nov 13, 2023
@willGraham01 willGraham01 transferred this issue from brainglobe/cellfinder Dec 13, 2023
@willGraham01 willGraham01 added the migrated-from-cellfinder For issues that were inherited from the migration of cellfinder into this package. label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request migrated-from-cellfinder For issues that were inherited from the migration of cellfinder into this package.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants