Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a save_any function to image_io #50

Closed
K-Meech opened this issue Mar 13, 2024 · 5 comments · Fixed by #51
Closed

Add a save_any function to image_io #50

K-Meech opened this issue Mar 13, 2024 · 5 comments · Fixed by #51
Labels
enhancement New feature or request

Comments

@K-Meech
Copy link
Contributor

K-Meech commented Mar 13, 2024

Image_io has a load_any function that recognises the image file extension and calls the appropriate loading function. It would be useful to add a corresponding save_any function, similar to here

@K-Meech K-Meech added the enhancement New feature or request label Mar 13, 2024
@K-Meech
Copy link
Contributor Author

K-Meech commented Mar 14, 2024

We should also support saving a txt file with a tiff sequence as part of this. We already support loading such files via load_any and load_img_sequence

@adamltyson
Copy link
Member

We should also support saving a txt file with a tiff sequence as part of this.

I don't think we have any need for this TBH. The image_io module is now just to support BrainGlobe tools, and none need to write to this format.

@alessandrofelder
Copy link
Member

alessandrofelder commented Mar 14, 2024

Do you think BrainGlobe tools will need to read this format @adamltyson ?

@adamltyson
Copy link
Member

It was included for historical reasons to support brainreg & brainmapper. I think it's worth keeping as long as it isn't too much overhead.

@K-Meech
Copy link
Contributor Author

K-Meech commented Mar 14, 2024

I have a working version with tests updated for both save_any and txt file writing. I can move the txt file writing back to test_image_io if that's preferred though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants