Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ship brainrender #14

Closed
willGraham01 opened this issue Jul 3, 2023 · 5 comments · Fixed by #37
Closed

[Feature] Ship brainrender #14

willGraham01 opened this issue Jul 3, 2023 · 5 comments · Fixed by #37
Assignees
Labels
enhancement New feature or request

Comments

@willGraham01
Copy link
Collaborator

willGraham01 commented Jul 3, 2023

Is your feature request related to a problem? Please describe.
brainrender should be shipped as part of the meta-package.

Describe the solution you'd like
As above.

  • Add brainrender to the list of pip dependencies.
  • Add brainrender to conda-forge so the conda package can install it.
@adamltyson
Copy link
Member

No rush on this. I think there's a bit of work to do to get brainrender up to date, and compatible with the dependencies of the other tools.

@willGraham01 willGraham01 self-assigned this Jul 3, 2023
@willGraham01
Copy link
Collaborator Author

No problem - it also looks like brainrender depends on morphio, which is another thing on my conda to-do list.

Barring the Python 3.8 hard-dependencies though, we could ship this with the meta-package (via pip) as it is.

@adamltyson
Copy link
Member

I think there are quite a few other dependency conflicts. Should be good once brainglobe/brainrender#235 is merged.

@adamltyson
Copy link
Member

brainrender should be good to go now I think.

@willGraham01
Copy link
Collaborator Author

brainrender should be good to go now I think.

Will open up a PR for the PyPI package at least. We still depend on morphapi (hence morphio) so won't be available on conda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants