-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] allen_cord_20um
meshes are not centered
#330
Comments
This issue has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/allen-spinal-cord-atlas-is-off-axis/99539/2 |
Currently, the left/right split is done by calculating the For some reason the However, this breaks this functionality for the I noticed that the Not sure how to proceed, one idea I had was to take the geometric center for atlases that are marked as symmetric and rely on the |
Yep, if they're symmetrical we programmatically generate the hemisphere image, otherwise it's packaged along with the atlas. TBH I don't know if that's correct for this atlas though. |
This specific issue has been closed by brainglobe/brainrender#375, and these issues have been raised to fix specific atlases: |
This image.sc issue led me to do some digging, and it looks like:
However, the meshes don't seem be centered. I'm not 100% sure what that means TBH, as I don't know exactly what the coordinate system is that they're in. However, when the meshes are cut down the midline by vedo (via brainrender), you don't get exactly half. To reproduce:
Gives:
This then seems to cause the downstream issues in
brainrender-heatmap
. Not sure if other atlas have this issue.The text was updated successfully, but these errors were encountered: