From b3375f25500742ce1ff7c6921033df38613b532b Mon Sep 17 00:00:00 2001
From: Brain <braindigitalis@users.noreply.github.com>
Date: Sun, 24 Sep 2023 10:44:25 +0100
Subject: [PATCH] fix: awful wrong indentation in stringops (#885)

---
 include/dpp/stringops.h | 34 ++++++++++++++++++++--------------
 1 file changed, 20 insertions(+), 14 deletions(-)

diff --git a/include/dpp/stringops.h b/include/dpp/stringops.h
index 77de2e1718..279d84c6c9 100644
--- a/include/dpp/stringops.h
+++ b/include/dpp/stringops.h
@@ -29,6 +29,7 @@
 #include <algorithm>
 #include <sstream>
 #include <iostream>
+#include <charconv>
 
 namespace dpp {
 /**
@@ -40,9 +41,9 @@ namespace dpp {
  */
 template <typename T> std::basic_string<T> lowercase(const std::basic_string<T>& s)
 {
-    std::basic_string<T> s2 = s;
-    std::transform(s2.begin(), s2.end(), s2.begin(), tolower);
-    return s2;
+	std::basic_string<T> s2 = s;
+	std::transform(s2.begin(), s2.end(), s2.begin(), tolower);
+	return s2;
 }
 
 /**
@@ -54,9 +55,9 @@ template <typename T> std::basic_string<T> lowercase(const std::basic_string<T>&
  */
 template <typename T> std::basic_string<T> uppercase(const std::basic_string<T>& s)
 {
-    std::basic_string<T> s2 = s;
-    std::transform(s2.begin(), s2.end(), s2.begin(), toupper);
-    return s2;
+	std::basic_string<T> s2 = s;
+	std::transform(s2.begin(), s2.end(), s2.begin(), toupper);
+	return s2;
 }
 
 /**
@@ -185,14 +186,19 @@ template <int> int from_string(const std::string &s)
  * 
  * @tparam T numeric type
  * @param i numeric value
+ * @param leading_zeroes set to false if you don't want the leading zeroes in the output
  * @return std::string value in hex, the length will be 2* the raw size of the type
  */
-template <typename T> std::string to_hex(T i)
+template <typename T> std::string to_hex(T i, bool leading_zeroes = true)
 {
-  std::stringstream stream;
-	stream.imbue(std::locale::classic());
-  stream << std::setfill('0') << std::setw(sizeof(T)*2) << std::hex << i;
-  return stream.str();
+	char str[26] = { 0 };
+	size_t size = sizeof(T) * 2;
+	std::to_chars(std::begin(str), std::end(str), i, 16);
+	std::string out{str};
+	if (leading_zeroes && out.length() < size) {
+		out.insert(out.begin(), size - out.length(), '0');
+	}
+	return out;
 }
 
 /**
@@ -205,10 +211,10 @@ template <typename T> std::string to_hex(T i)
  */
 template <typename T> std::string leading_zeroes(T i, size_t width)
 {
-  std::stringstream stream;
+	std::stringstream stream;
 	stream.imbue(std::locale::classic());
-  stream << std::setfill('0') << std::setw((int)width) << std::dec << i;
-  return stream.str();
+	stream << std::setfill('0') << std::setw((int)width) << std::dec << i;
+	return stream.str();
 }
 
 } // namespace dpp