From 96654b6f65f1c85abd382beb3430f26c73b13937 Mon Sep 17 00:00:00 2001
From: Craig Edwards <craigedwards@brainbox.cc>
Date: Mon, 16 Oct 2023 21:02:13 +0000
Subject: [PATCH] fix: make modals work again by making to_json_impl and
 fill_from_json virtual

---
 include/dpp/appcommand.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/dpp/appcommand.h b/include/dpp/appcommand.h
index 068a58f740..96f7b2cd66 100644
--- a/include/dpp/appcommand.h
+++ b/include/dpp/appcommand.h
@@ -326,14 +326,14 @@ struct DPP_EXPORT interaction_response : public json_interface<interaction_respo
 	 * @param j JSON to fill from
 	 * @return interaction_response& Reference to self
 	 */
-	interaction_response& fill_from_json_impl(nlohmann::json* j);
+	virtual interaction_response& fill_from_json_impl(nlohmann::json* j);
 
 	/**
 	 * @brief Build json for this object
 	 *
 	 * @return json JSON object
 	 */
-	json to_json_impl(bool with_id = false) const;
+	virtual json to_json_impl(bool with_id = false) const;
 
 public:
 	/**
@@ -415,7 +415,7 @@ struct DPP_EXPORT interaction_modal_response : public interaction_response, publ
 	 * @param j JSON to fill from
 	 * @return interaction_response& Reference to self
 	 */
-	interaction_modal_response& fill_from_json_impl(nlohmann::json* j);
+	virtual interaction_modal_response& fill_from_json_impl(nlohmann::json* j);
 
 	/**
 	 * @brief Build a json for this object
@@ -423,7 +423,7 @@ struct DPP_EXPORT interaction_modal_response : public interaction_response, publ
 	 *
 	 * @return json JSON object
 	 */
-	json to_json_impl(bool with_id = false) const;
+	virtual json to_json_impl(bool with_id = false) const;
 
 public:
 	/**