From 7e7a0e3648ac1139a0247587cff22a89db85a0e1 Mon Sep 17 00:00:00 2001 From: Craig Edwards Date: Wed, 18 Dec 2024 13:29:41 +0000 Subject: [PATCH] ci: remove ctest, it is ass --- .github/workflows/ci.yml | 4 ++-- src/dpp/sslclient.cpp | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 89e025ae05..231d643498 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -96,7 +96,7 @@ jobs: - name: Run unit tests if: ${{ matrix.cfg.ctest == 'yes' }} - run: cd build && ctest -VV + run: cd build/library && ./unittest env: DPP_UNIT_TEST_TOKEN: ${{secrets.DPP_UNIT_TEST_TOKEN}} TEST_GUILD_ID: ${{secrets.TEST_GUILD_ID}} @@ -161,7 +161,7 @@ jobs: DONT_RUN_VCPKG: true - name: Run offline unit tests - run: cd build && ctest -VV + run: cd build/library && ./unittest windows: # Windows x64 and x86 build matrix permissions: diff --git a/src/dpp/sslclient.cpp b/src/dpp/sslclient.cpp index 02df3b7b8d..324a2d0f7f 100644 --- a/src/dpp/sslclient.cpp +++ b/src/dpp/sslclient.cpp @@ -53,9 +53,6 @@ #include #include -/* Maximum allowed time in milliseconds for socket read/write timeouts and connect() */ -constexpr uint16_t SOCKET_OP_TIMEOUT{5000}; - namespace dpp { /**