New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce benchmark identifier equivalent to registry identifier #35

Open

mschrimpf opened this issue May 23, 2023 · 0 comments

Member

mschrimpf commented May 23, 2023 •

edited

Loading

it is currently possible to construct a case like the following:

class MyBenchmark(BenchmarkBase):
    def __init__(self):
        super(MyBenchmark, self).__init__(
            identifier='identifier2', ...)

benchmark_registry['identifier1'] = MyBenchmark

The identifier in the registry can be different from the identifier in the benchmark itself and we currently have no way of catching it.

To connect to the real world, this has lead to a bug with SyntaxGym in language for example (brain-score/language#183).

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment