#284 add flip preference dialog design #285
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuevval
added
enhancement
zuevval
force-pushed
the
feature/284-flip-dialog
branch
from
0367e2a to
206cabe
Compare
|
@zuevval what is the status of this PR? |
I will decide after June 19th. As far as I remember, this dialog caused problems with accessibility. Also, I doubt that it's a good idea to ask the user to choose the value of this preference when he has little experience with the app; and now that we introduced a visible label for each dot I hope sighted users are not confused anymore. I'll think about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #284