-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zooming to bottom center of image on iPad (possibly all iOS) #7
Comments
Hi Brad, Sorry to double post. I have been looking into this quite extensively and notice a few issues, predominantly on mobile.
|
Hi Alex,
Unfortunately I don't have an iOS device at all, so I can't troubleshoot. I can only try to speculate by looking at the code and playing what-if. The more tidbits of info you can provide, the better. |
Would the following be consistent what you are seeing in your first two points: The image is being zoomed in slightly on initial load, even though the image dimensions perfectly match the container dimensions. There is slight overflow. But, when swiping up or down, neither the image nor the page moves at all. If so, it would suggest that the overflow is unexpected and somehow 'out of reach.' It would suggest that there is some unexpected dimension that is not being taken into account. |
Can you send a link to a repro? |
Hi Brad, I think you are correct, the component consuming the Y axis swipe must be related to the image being slightly zoomed on render. However, this is occurring on both my implementation and in your demo pages on iOS devices. I am still unsure as to why it is only zooming to the bottom center on pinch in my implementation. Unfortunately I do not have a link to the repo as it is private and I am unable to open it up publicly. |
If you pass debug={true} to the component, it will overlay a div with some debug info. Can you tell me what it says? Can you also send the dimensions of the image itself? |
Hi Brad,
Im not 100% sure if this is an issue with the pinch and zoom component specifically, so apologies if this is not related: I am noticing that on pinch, the zoom is always going to the bottom center of the image on an iPad and iPhone, regardless of where I pinch on the image.
The reason I say I'm not 100% sure is because it seems to work perfectly fine on iPad and iPhone on your demo pages.
I was therefore just wondering if you had noticed this, or are doing anything specific when implementing this onto a page?
The text was updated successfully, but these errors were encountered: