Is there some checking when you commit session/voteSync?

[MRegnard]

Hi again!
Sorry to ask so many questions, but I am working on a big and difficult update. And I have almost finished, I have just one last issue. After that, I will do only what I know how to do for a long long time.

My issue is that, for some special votes, if a player raises a hand, this hand is not committed for other users. This happens only if there is no nominee, and so no red clock on the screen (in this case, I coded such as the blue clock move instead of the red one).

Since this doesn't prevent the player to raise a hand for their part, I think that the issue is only for the commit. Is there some checking when you commit session/voteSync? I mean some checking which can cancel this commit and so I must adapt?

Thanks in advance

[bra1n]

I assume you mean when a player raises their hand during a vote, right? This message is called "vote" and triggers a "handleVote" on the other players / storyteller clients: https://github.com/bra1n/townsquare/blob/develop/src/store/socket.js#L771
The code checks if the vote is not locked yet, which would always fail if there was no actual nomination / vote happening, so you'd have to adjust that code, would be my guess.

[MRegnard]

Oh yes, that's what I needed!
That's said, since we are talking about socket.js, what are the goal of the functions lockVote and _handleLock, and when are they called?
Because if they could be used in my special vote, I have to adapt them too.

[bra1n]

They are being used to synchronize the clock hand. A "locked vote" is a vote that has been counted once the clock hand has moved past it. handleLock is the player-side of the code, whereas lockVote is the ST side. (since the ST is the authority for running the vote)