Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space and lasso tool not moving groups and text annotations inside a Collaboration #2226

Open
fagarma opened this issue Aug 30, 2024 · 8 comments
Labels
backlog Queued in backlog bug Something isn't working modeling refactoring support Tracks features that make diagram changes easier ux

Comments

@fagarma
Copy link

fagarma commented Aug 30, 2024

Describe the Bug

When using the Space Tool or the Lasso Tool in bpmn-js version 17.9.2, the tools do not move groups or text annotations when clicking inside a bpmn:Collaboration. However, all other elements are moved correctly. This issue appears to be specific to elements within a Collaboration.

Steps to Reproduce

  1. Open a BPMN diagram in the editor.
  2. Add a bpmn:Collaboration with various elements, including groups and text annotations.
  3. Select the Space Tool or Lasso Tool.
  4. Click and drag to create space or select elements inside the Collaboration.
  5. Observe that groups and text annotations are not moved, while other elements are moved as expected.

Expected Behavior

All elements, including groups and text annotations, should be moved when using the Space Tool or Lasso Tool.

Environment

  • Browser: Chrome Version 126.0.6478.127
  • OS: Windows 11 Pro
  • Library version: bpmn-js 17.9.2

bug space tool

@fagarma fagarma added the bug Something isn't working label Aug 30, 2024
@jarekdanielak
Copy link
Contributor

The text annotation will not move with other elements unless it's also selected with the lasso. Same way it won't move if you move its parent element. It might be a problem when using lasso inside of collaboration. You can try to select elements inside the collaboration with lasso tool and shift click the annotation to move it all together.

As for the group, I do indeed see some inconsistencies when trying to lasso it, but could you please share a screen recording of your exact incorrect behavior so that we are on the same page?

@fagarma
Copy link
Author

fagarma commented Sep 2, 2024

The text annotation will not move with other elements unless it's also selected with the lasso. Same way it won't move if you move its parent element. It might be a problem when using lasso inside of collaboration. You can try to select elements inside the collaboration with lasso tool and shift click the annotation to move it all together.

As for the group, I do indeed see some inconsistencies when trying to lasso it, but could you please share a screen recording of your exact incorrect behavior so that we are on the same page?

space.tool.mp4

If I'm not mistaken the space tool should move everything inside the collaboration, but it won't move text annotations or groups.

@jarekdanielak
Copy link
Contributor

Space tool is local by default. Try using it while holding Shift key.

@nikku
Copy link
Member

nikku commented Sep 9, 2024

I tend to agree with @fagarma that the desired behavior would be for text annotations (they live outside of the process) should move with the annotated target.

@fagarma Could you check if camunda/camunda-modeler#4172, reported in an app using bpmn-js is the same error?

@fagarma
Copy link
Author

fagarma commented Sep 11, 2024

I tend to agree with @fagarma that the desired behavior would be for text annotations (they live outside of the process) should move with the annotated target.

@fagarma Could you check if camunda/camunda-modeler#4172, reported in an app using bpmn-js is the same error?

Yes, it is the same issue as reported there

@nikku nikku added modeling ux backlog Queued in backlog refactoring support Tracks features that make diagram changes easier labels Sep 12, 2024
@nikku
Copy link
Member

nikku commented Sep 12, 2024

Moving to backlog, awaiting further user feedback.

@fagarma
Copy link
Author

fagarma commented Sep 13, 2024

Moving to backlog, awaiting further user feedback.

Sorry, do you need anything more from me?

@nikku
Copy link
Member

nikku commented Sep 13, 2024

Moving to backlog, awaiting further user feedback.

Sorry, do you need anything more from me?> Sorry, do you need anything more from me?

I just realized how my previous comment was very confusing. My appologies.

We don't need additional information from you, but seek validation from other users, too. Thank you, again, for the report. 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working modeling refactoring support Tracks features that make diagram changes easier ux
Projects
None yet
Development

No branches or pull requests

3 participants