Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The template element(hover) icon rendering error #2206

Open
zxuanhong opened this issue Jul 21, 2024 · 4 comments
Open

The template element(hover) icon rendering error #2206

zxuanhong opened this issue Jul 21, 2024 · 4 comments
Labels
backlog Queued in backlog bug Something isn't working element templates good first issue Good for newcomers modeling

Comments

@zxuanhong
Copy link

zxuanhong commented Jul 21, 2024

Describe the Bug

An element is backed by an element template with an attached icon. If I preview the element for append, then the custom icon is not shown.

image

Describe the solution

The preview picks up the custom icon, if @bpmn-io/element-template-icon-renderer is hooked up.

Environment

  • Browser: Chrome 126.0.6478.63
  • OS: macos 14.5
  • Library version: bpmn-js 17.9.1
@zxuanhong zxuanhong added the bug Something isn't working label Jul 21, 2024
@zxuanhong zxuanhong changed the title The template element(append on hover) icon cannot be render The template element(append on hover) icon rendering error Jul 21, 2024
@nikku
Copy link
Member

nikku commented Jul 22, 2024

@zxuanhong to verify if I understand you correctly: You want the preview to render the element template icon?

@zxuanhong
Copy link
Author

zxuanhong commented Jul 22, 2024

@nikku video

iShot_2024-07-22_17.17.35.mp4

image

@zxuanhong zxuanhong changed the title The template element(append on hover) icon rendering error The template element(hover) icon rendering error Jul 22, 2024
@nikku
Copy link
Member

nikku commented Jul 22, 2024

Thanks updated accordingly.

@nikku nikku added backlog Queued in backlog modeling good first issue Good for newcomers labels Jul 22, 2024
@zxuanhong
Copy link
Author

zxuanhong commented Jul 22, 2024

  1. We will add some frequently used templates to the ContextPad. For example: sending sms message, sending email. But the hover template element icon rendering is wrong.
  2. Clicking or dragging the template element icon renders correctly, but the hover exception makes the effect inconsistent.
  3. For the above reasons, I think this is a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working element templates good first issue Good for newcomers modeling
Projects
None yet
Development

No branches or pull requests

2 participants