Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Message Flow in Process Not Prevented #1902

Open
philippfromme opened this issue May 3, 2023 · 4 comments · May be fixed by #1904
Open

Creating Message Flow in Process Not Prevented #1902

philippfromme opened this issue May 3, 2023 · 4 comments · May be fixed by #1904
Assignees
Labels
backlog Queued in backlog bug Something isn't working

Comments

@philippfromme
Copy link
Contributor

Describe the Bug

The rules don't prevent message flows from being created in processes when multiple elements are created at once. The rules check only if the message flow can connect source and target but doesn't check the parent.

brave_cNEljtde75

Steps to Reproduce

  1. Copy message flow including source and target
  2. Delete all elements (creates process)
  3. Paste
  4. 💥

Expected Behavior

Create is prevented

Environment

  • Library version: 13.0.4
@philippfromme philippfromme added the bug Something isn't working label May 3, 2023
@philippfromme philippfromme self-assigned this May 3, 2023
@nikku
Copy link
Member

nikku commented May 3, 2023

I'm not sure if we want to prevent create in this case. In fact we more or less consistently go by "just do it and adapt", or "do the hard work and make it simple".

I'd argue that pasting in a scenario like the following should just work, just with message flows not pasted:

capture kZGW8z_optimized

But it does not 😢

@philippfromme
Copy link
Contributor Author

I'd argue that pasting in a scenario like the following should just work, just with message flows not pasted:

I was considering that, too, but wasn't sure if that would look broken.

@barmac
Copy link
Member

barmac commented May 4, 2023

What should happen if some elements are already present on the diagram? How about if the diagram is already a collaboration vs. a process diagram with elements? If we are to create missing participants, should the referred processes be executable or not? Which participant should refer to already existing process?

I am not sure about the answers to the questions above. Therefore, I'd suggest to start small with message flows removal. The user can always wrap elements in participant(s), but moving from collaboration to a single process diagram is much more cumbersome.

@philippfromme
Copy link
Contributor Author

I discussed this again with @nikku. We concluded that removing the message flows is the least intrusive option for now. Copying, as shown in the recording, is considered an edge case. We would assume that you either don't copy message flows or you copy the participants as well. We're going to remove the message flows on paste if the participants weren't copied.

@philippfromme philippfromme linked a pull request May 4, 2023 that will close this issue
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 4, 2023
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels May 9, 2023
@nikku nikku added the backlog Queued in backlog label Jun 6, 2023 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants