Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

Travis tool sometimes checks wrong commits #30

Open
TomSeldon opened this issue Dec 16, 2016 · 0 comments
Open

Travis tool sometimes checks wrong commits #30

TomSeldon opened this issue Dec 16, 2016 · 0 comments
Labels

Comments

@TomSeldon
Copy link
Contributor

For a pull request build (e.g. when merging develop into master) we use the environment variable TRAVIS_COMMIT_RANGE to work out what commits we need to check.

This seems to work correctly in most cases, however it's been observed that in some cases that SHA range (or perhaps and more likely the way we're interpreting it) will include commits that aren't part of the pull request.

Difficult to replicate and I'm not aware of any specific replication steps, but it's been seen often enough to be an issue.

@TomSeldon TomSeldon added the bug label Dec 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant